Service Manager. Credit Goods into Stock

[DannyC]

Hi,

On the Service Manager, Customer Returns tab, I want to change the warehouse for the Credit Note when Credit Goods Into Stock is ticked.
If not ticked, just leave as current warehouse.

I have it working - to a point.
The credit note warehouse is changing, but it seems to be setting the overall Jiwa warehouse without changing the bottom status bar. I know because when I open sales orders or purchase orders or other module the warehouse of the opened form is the adjusted warehouse.

How can I stop that from happening, so that if Credit Goods into Stock is ticked, I can set the warehouse the credit should go to without changing the Jiwa current warehouse?
This is my code so far

Code: Select all

Public Class BusinessLogicPlugin
    Inherits System.MarshalByRefObject
    Implements JiwaApplication.IJiwaBusinessLogicPlugin
   'Private _ServiceJob As JiwaFinancials.Jiwa.JiwaServiceManager.Job
    Public Overrides Function InitializeLifetimeService() As Object
        ' returning null here will prevent the lease manager
        ' from deleting the Object.
        Return Nothing
    End Function

    Public Sub Setup(ByVal JiwaBusinessLogic As JiwaApplication.IJiwaBusinessLogic, ByVal Plugin As JiwaApplication.Plugin.Plugin) Implements JiwaApplication.IJiwaBusinessLogicPlugin.Setup
      If TypeOf(JiwaBusinessLogic) Is JiwaFinancials.Jiwa.JiwaServiceManager.Job Then
         Dim jobObject As JiwaFinancials.Jiwa.JiwaServiceManager.Job = DirectCast(JiwaBusinessLogic, JiwaFinancials.Jiwa.JiwaServiceManager.Job)
         AddHandler jobObject.CreateCustomerReturnCreditNoteBeforeSalesOrderSave, AddressOf ChgCreditWarehouse
         '_ServiceJob = jobObject   
      End If
    End Sub
   
   Public Sub ChgCreditWarehouse(ByVal SalesOrder As JiwaSales.SalesOrder.SalesOrder)
      If SalesOrder.CreditIntoStock = True Then
         ' salesOrder.LogicalWarehouseResidingIn.IN_LogicalID = "DEB9E973927E486B8E81"        'This doesn't work
         SalesOrder.Warehouse.IN_LogicalID = "DEB9E973927E486B8E81"
      Else
         Exit Sub
      End If
   End Sub
End Class

Second question, ideally I'd like to pop up a warehouse selection box so the user can choose the warehouse. Not quite so important but would be handy.

Cheers

[DannyC]

Hi guys,

Never mind with the original post.
I think I have this one sussed. I managed to get a warehouse selection to pop up and the destination credit note gets the chosen warehouse.

If anyone wants to see the plugin, I can post it here.

Cheers

[DannyC]

Hi,

Damn - nearly had it working!
So although I have the credit note getting created in the selected warehouse, unfortunately the stock is landing in the original warehouse. It needs to go into the selected warehouse.
I can't work out how to get the SOH to land in the selected warehouse.
Hoping you can help me on this one.

Here is the whole BusinessLogicPlugin class.

Code: Select all

Public Class BusinessLogicPlugin
    Inherits System.MarshalByRefObject
    Implements JiwaApplication.IJiwaBusinessLogicPlugin
    Public Overrides Function InitializeLifetimeService() As Object
        ' returning null here will prevent the lease manager
        ' from deleting the Object.
        Return Nothing
    End Function

    Public Sub Setup(ByVal JiwaBusinessLogic As JiwaApplication.IJiwaBusinessLogic, ByVal Plugin As JiwaApplication.Plugin.Plugin) Implements JiwaApplication.IJiwaBusinessLogicPlugin.Setup
      If TypeOf(JiwaBusinessLogic) Is JiwaFinancials.Jiwa.JiwaServiceManager.Job Then
         Dim jobObject As JiwaFinancials.Jiwa.JiwaServiceManager.Job = DirectCast(JiwaBusinessLogic, JiwaFinancials.Jiwa.JiwaServiceManager.Job)
         AddHandler jobObject.CreateCustomerReturnCreditNoteBeforeSalesOrderSave, AddressOf ChgCreditWarehouse
      End If
    End Sub
   
   Public Sub ChgCreditWarehouse(ByVal SalesOrder As JiwaSales.SalesOrder.SalesOrder)
      If SalesOrder.CreditIntoStock = True Then
         With JiwaApplication.Manager.Instance.Search   
            .Clear
            .CurrentOption = 1            
            .SetDefaultSearch(JiwaApplication.JiwaSearch.clsSearch.SearchModes.jswLogicalWarehouse)
            .UsePinBoard = False         
            
            If .Show(salesOrder.Client) = System.Windows.Forms.DialogResult.OK Then
               If .Results.Count <> 0 Then
'                  msgbox(.Fields(1).FieldValue.ToString)                  
                  Dim logicalWarehouse As JiwaApplication.Inventory.Warehouse.LogicalWarehouse = JiwaApplication.Manager.Instance.PhysicalWarehouseCollection.FindLogicalWarehouse(.Fields(1).FieldValue.ToString)
                  Dim logicalWH_Entity As New JiwaApplication.Entities.LogicalWarehouse
                  logicalWH_Entity.ReadRecord(.Fields(1).FieldValue.ToString)

                  If logicalWarehouse IsNot Nothing Then
                     salesOrder.LogicalWarehouseResidingIn = logicalWH_Entity
                     salesOrder.Warehouse = logicalWarehouse
'                     msgbox (salesOrder.LogicalWarehouseResidingIn.Description)
                  End If
                                    
               Else
                  Throw New JiwaApplication.Exceptions.ClientCancelledException
               End If
            Else
               Throw New JiwaApplication.Exceptions.ClientCancelledException
            End If
         End With


      Else
         Exit Sub
      End If
   End Sub
End Class


Thanks

Danny

[Scott.Pearce]

The implementation of warehouses seems to be a little muddled in sales orders. Further, if we change the warehouse of the sales order after adding the lines, the lines don't get told about the change! So what we can do is remove and re-add the lines after we change warehouse:

Code: Select all

Public Sub ChgCreditWarehouse(ByVal SalesOrder As JiwaSales.SalesOrder.SalesOrder)
  If SalesOrder.CreditIntoStock = True Then
    With JiwaApplication.Manager.Instance.Search   
      .Clear
      .CurrentOption = 1           
      .SetDefaultSearch(JiwaApplication.JiwaSearch.clsSearch.SearchModes.jswLogicalWarehouse)
      .UsePinBoard = False         
      
      If .Show(salesOrder.Client) = System.Windows.Forms.DialogResult.OK Then
         If .Results.Count <> 0 Then
         Dim IN_LogicalID As String = .Fields(1).FieldValue.ToString()
         If IN_LogicalID IsNot Nothing AndAlso IN_LogicalID.Trim.Length > 0 Then
            Dim selectedLogicalWarehouse As JiwaApplication.Inventory.Warehouse.LogicalWarehouse = JiwaApplication.Manager.Instance.PhysicalWarehouseCollection.FindLogicalWarehouse(IN_LogicalID) 
            If selectedLogicalWarehouse IsNot Nothing Then
               salesOrder.Warehouse =  selectedLogicalWarehouse
               salesOrder.SalesOrderLines.RemoveAll
               Dim selectedTask As JiwaFinancials.Jiwa.JiwaServiceManager.Task = jobObject.Tasks(jobObject.SelectedTaskNo)
               selectedTask.CustomerReturns.AddToSalesOrder (salesOrder)
            End If
         End If
         End If
      End If
    End With
  End If
End Sub      


Note that the ChgCreditWarehouse function requires a job object, so I made your jobObject declaration global to the class. Please find the full plugin attached.

[DannyC]

Thx Scott.

When I use your code, I get an error on this line

Code: Select all

Dim selectedTask As JiwaFinancials.Jiwa.JiwaServiceManager.Task = jobObject.Tasks(jobObject.SelectedTaskNo)


Object reference not set to an instance of an object

In JiwaDemo database, when I import the plugin I get a different error on this line

Code: Select all

salesOrder.SalesOrderLines.RemoveAll

Argument 'Key' is not a valid value.
Module: Remove

Cheers

[Scott.Pearce]

Which version are you importing into?

[DannyC]

7.0.149

[Scott.Pearce]

I just downloaded and imported the plugin into a fresh 7.0.149 demo database and then tested a customer return. No problems, plugin worked fine.