Async Delegate Doesn't Save Order in Any Event

[Mike.Sheen]

Couldn't that cause a concurrency exception, if someone then edited the sales order?

Yes, but there is only so much we can do.

You could catch the concurrency exception and in the catch re-read the sales order then, set the custom field value (not call external API again - you'd already have the value you needed from it) and then save.

That would be good enough.

[Mike.Sheen]

So, the revised guidance is:

Code: Select all

salesOrder.ProcessingEnd += async delegate (object sender, EventArgs e)
{
   // create new sales order object   
   SalesOrder tempOrder = Manager.BusinessLogicFactory.CreateBusinessLogic<SalesOrder>(null);
   // read order (use salesOrder.RecID)
   tempOrder .Read(salesOrder.RecID);
   // Make external API call
   var orderID = ExternalAPI();
   // update custom field (on the sales order instance we created and read in here)
   tempOrder.CustomFielValues.SetValue<string>("OrderID", orderID);
   try
   {
      // Save (not the sales order outside the delegate, the one we created in here)
     tempOrder.Save();
   }
   catch (ConcurrencyConflictException)
   {
     // re-read and try saving again
     tempOrder .Read(salesOrder.RecID);
     tempOrder.CustomFielValues.SetValue<string>("OrderID", orderID);
     tempOrder.Save();
   }
}