Jiwa

I have an issue I can't quite nail, with a Help I am developing to ease direct database access ...

USAGE:

Code: Select all

var taxCodes = PluginHelper.SqlDataTable("SELECT TaxID, Description FROM TX_Main ORDER BY Description");
foreach (DataRow row in taxCodes.Rows) BASCodeUltraComboEditor.Items.Add(row["TaxID"].ToString(), row["Description"].ToString());

HELPER:

Code: Select all

public static class PluginHelper
{
    public static DataTable SqlDataTable(string sql, SqlParameter[] paramList = null)
    {
        DataTable table = new DataTable();
        //try
        //{
        JiwaFinancials.Jiwa.JiwaODBC.database databaseObject = JiwaFinancials.Jiwa.JiwaApplication.Manager.Instance.Database;
        using (SqlCommand cmd = new SqlCommand(sql, databaseObject.SQLConnection, databaseObject.SQLTransaction))
        {
            if (paramList != null) cmd.Parameters.AddRange(paramList);
            cmd.Connection.Open();
            table.Load(cmd.ExecuteReader());
            cmd.Connection.Close();
        }
        //}
        //catch { }
        return table;
    }
}

(handling commented to see error)

ERROR:
The connection was not closed. The connection's current state is open. Module: TryOpenConnection

Can you point me in the right direction?

Cheers,
Neil

Hi Neil,

You're closing the Jiwa connection:

Code: Select all

cmd.Connection.Close();

Don't do that.

Mike

Thanks Mike,

I actually had just added that line in response to the "not closed" error. I have removed it again, but still get the same error.

Cheers,
Neil

You shouldn't be opening the connection either.

That's got it ... do you need my postal address to forward on a dunce hat?

lol