Creditor Purchase Lines Custom Fields - copying

[neil.interactit]

Hi guys,

Closely related, but rather than tacking this onto viewtopic.php?f=26&t=977#p3665, I'll post separately to avoid thread blurring.

Per that thread "BPay CRN" data entry is possible in the new column, but the client has just discovered that copying a creditor purchase does not copy the custom column values.

Should I specifically code the copying up, or is it ultimately more intuitive if you bake this into the various "Lines Custom Fields" throughout Jiwa? If you do, would it be worth an additional bool setting column on the plugin custom fields tab "Copyable" (or some better term!) to determine if the custom field values are copied or not when the parent is duplicated?

Cheers,
Neil.

[Mike.Sheen]

Should I specifically code the copying up, or is it ultimately more intuitive if you bake this into the various "Lines Custom Fields" throughout Jiwa? If you do, would it be worth an additional bool setting column on the plugin custom fields tab "Copyable" (or some better term!) to determine if the custom field values are copied or not when the parent is duplicated?

Hi Neil,

We found several different camps our customers were in:

• Always want to copy custom fields
• Never want to copy custom fields
• Conditionally want to copy custom fields
• Want to copy select custom fields (not all of them!)
• Want to conditionally copy select custom fields (not all of them - and only sometimes!)

And then the rules are mixed and matched between line custom fields and custom fields. So we so far have relied on plugins being implemented to suit the various needs.

But I like your idea of just adding a checkbox next to the custom field to indicate if the default behaviour should be to copy it or not - that would meet 90% of requirements - so that's logged as improvement DEV-6705.

In the meantime, attached is a plugin which copies all the line custom fields for creditor batch transactions when a creditor batch is copied.

Mike

Plugin Copy CR Batch Line Custom Fields.xml

Sample Plugin

(33.06 KiB) Downloaded 91 times

[neil.interactit]

Sweet! Many thanks Mike.

[neil.interactit]

Actually ... did you try hitting save after copying? Here, I'm seeing values appear OK after hitting copy, then disappear on save.

[Mike.Sheen]

Actually ... did you try hitting save after copying? Here, I'm seeing values appear OK after hitting copy, then disappear on save.

Yes - that's the behaviour without the plugin I supplied (which is a bug) - but with the supplied plugin saving after copying sees the values retained.

[neil.interactit]

Duh, I hadn't added CreditorBatchTrans to the business logic factory in my plugin. All good now!