Webhooks Bug??

[SBarnes]

The below code inserts into SY_WebhookMessage when an attempted post doesn't work, however it is not taking into account whether or not the subscriber itself is enabled.

Code: Select all

string sql = @"INSERT INTO SY_WebhookMessage(RecID, SY_WebhookSubscription_RecID, Body, ItemNo, Status, LastSavedDateTime, AddedDateTime, Retries)
                  SELECT NewID(), SY_WebhookSubscription.RecID, @Body,
                  COALESCE(QueueTable.MaximumItemNo, 0) + ROW_NUMBER() OVER (ORDER BY (SELECT NULL)),
                  0, SYSUTCDATETIME(), SYSUTCDATETIME(), 0
                  FROM SY_WebhookSubscription
                  CROSS JOIN (SELECT MAX(ItemNo) AS MaximumItemNo FROM SY_WebhookMessage) QueueTable
                  WHERE EventName = @EventName
                  ORDER BY SY_WebhookSubscription.ItemNo";


[Scott.Pearce]

https://service.jiwa.com.au/browse/DEV-8178

[SBarnes]

Thanks Scott,

It can be an even bigger issue because if you then re-enable the subscriber the api can run out of memory when there are too many items in SY_WebhookMessage that haven't be closed off with a response and the api loads them for processing, Mike is aware of this.