Suggested API improvment for working with controls on a form

[SBarnes]

Whilst Scott gave an excellent example of adding controls to a form (viewtopic.php?f=27&t=404&p=1306&hilit=add+control#p1306)

and you can use something like

if (JiwaForm.GetType() == typeof(JiwaFinancials.Jiwa.JiwaSalesUI.SalesOrder.SalesOrderEntryForm))
{
JiwaFinancials.Jiwa.JiwaSalesUI.SalesOrder.SalesOrderEntryForm salesform = (JiwaFinancials.Jiwa.JiwaSalesUI.SalesOrder.SalesOrderEntryForm)JiwaForm;
TableLayoutPanel parentpanel = (TableLayoutPanel)(salesform.Controls.Find("TableLayoutPanel2", true)[0]);
UltraTextEditor matchdelstate = (UltraTextEditor)(salesform.Controls.Find("txtDeliveryState", true)[0]);
}

to find controls would it be possible to add to the generic maintenance form a GetControlByName("ControlName", SearchChildren) function?

And some sort of SetControlValueByName and GetControlValueByName would also be nice if possible as well.

[Mike.Sheen]

Hi Stuart,

Bug 12928 has been added to address this

Mike

PS:

Also, instead of:

Code: Select all

if (JiwaForm.GetType() == typeof(JiwaFinancials.Jiwa.JiwaSalesUI.SalesOrder.SalesOrderEntryForm))

Why not use:

Code: Select all

if (JiwaForm is JiwaFinancials.Jiwa.JiwaSalesUI.SalesOrder.SalesOrderEntryForm)

I think they are equivalent - I tend to use the latter in C#, but perhaps I'm overlooking something.

[Scott.Pearce]

The .Net framework already has this:

Code: Select all

Control[] myControls = myForm.Controls.Find("MyControlName",true);


[SBarnes]

Hi Scott

Yes it does and the code I provided in the original post does that call but the problem is it assume that an array with element zero comes back every time which may not be the case I left out the error handling for simplicity what I was suggesting for a function was to cover of the error handling and probably return null/nothing if not found.