Debtor (and sometimes Creditor) Card - If you delete notes, it changes the Last Modified date on everything
And they've provided a screen shot which clearly shows all the notes for the debtor have the same date/time.
I confirmed that none of my plugins do anything with creditor or debtor notes.
Then I took a look at Remove<T> in JiwaCollection<T> using ILSpy, and I noticed this bit of logic:
- Code: Select all
enumerator = _Collection.GetEnumerator();
while (enumerator.MoveNext())
{
T val = Conversions.ToGenericParameter<T>(enumerator.Current);
if (val.ItemNo >= itemNo)
{
val.ItemNo--;
}
}
That val.ItemNo-- will be triggering NotifyPropertyChanged on the item, and so the item is 'modified', and gets saved with the current date/time the next time the collection is saved.
From a UX experience, this is a bit 'unexpected', because they don't see 'ItemNo'.
Is it really necessary to renumber all the items? ItemNo is an int, so there is plenty of capacity.
Alternatively, either LastModified should not change when ItemNo has been changed, or we need a different field that only changes in response to a user change.
